[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms |
Date: |
Fri, 26 Oct 2012 14:24:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 |
Hi,
> +typedef struct EHCItfState {
> + union {
> + PCIDevice pcidev;
> + };
> + struct EHCIState ehci;
> +} EHCIItfState;
I still think we should have EHCIPCIState here, then add a
EHCISysbusState variant for sysbus. Everybody else does it this way
(ohci, esp, serial, ...) and I'd like ehci follow. Also makes it easier
to split the source code into core, pci and sysbus pieces, i.e. move all
the pci bits to hcd-ehci-pci.c and compile only for targets with pci
support.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 00/11] Sysbus EHCI + Zynq USB., Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 01/11] dma: Define dma_context_memory and use in sysbus-ohci, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 02/11] usb/ehci: Use class_data to init PCI variations, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 03/11] usb/ehci: parameterise the register region offsets, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 04/11] usb/ehci: Abstract away PCI DMA API, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms, Peter Crosthwaite, 2012/10/26
- Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH v2 06/11] usb/ehci: Add Sysbus Infrastructure, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 07/11] usb/ehci: Add Xilinx ps7 USB controller, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 09/11] usb/ehci: Guard definition of EHCI_DEBUG, Peter Crosthwaite, 2012/10/26
- [Qemu-devel] [PATCH v2 11/11] usb/ehci: Put RAM in undefined MMIO regions, Peter Crosthwaite, 2012/10/26