Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

[Sebastian Bauer]

Hi!

Am 26.10.2012 14:00, schrieb Gerd Hoffmann:
> Wrong fix I think.  Just moving "port->portsc |= PORTSC_CSC" out of 
> the
> "if (running)" should do.  usb-next already has a patch which fixes 
> this:

I'm not sure about that. According to the spec, when the hc is set to 
running mode (p.70)

"At this point, the host controller is up and running and the Root Hub 
ports (5.4.8) will begin reporting device
connects"

Therefore I made it slightly more complex. Granted, as far as I can 
see, the spec doesn't explicitly state that the devices are not reported 
when being not in the running mode.

It probably would be easier to mask out relevant bits when reading the 
port registers if the hcd would be strict.

> http://www.kraxel.org/cgit/qemu/commit/?h=rebase/usb-next&id=84f84686c701731964a515e9bbcfb475cfc1de8c

Nice, this wasn't there when I looked into this today. However, does 
this commit also ensure that the status port change event is generated 
when the hc is switched to running mode and there were already some 
devices present?

Bye,
Sebastian