Re: [Qemu-devel] [PATCH] tests/tcg: new test for i386 FPREM and FPREM1

[Peter Maydell]

On 29 October 2012 07:45, Catalin Patulea <address@hidden> wrote:
> This is setting the stage for a cleanup of FPREM and FPREM1 helpers while 
> being
> sure that they behave same as bare metal.
>
> The test constructs operands using combinations of corner cases for the
> floating-point bitfields and prints operands, result and FPU status word for
> FPREM and FPREM1. The outputs can then be compared between bare metal and 
> QEMU.
> The 'run-test-i386-fprem' make target does just that.
>
> Signed-off-by: Catalin Patulea <address@hidden>
> ---
> Here is a refresh of the patch originally sent in back in July:
> https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02054.html
>
> At the time, there was some concern about use of bitfields. QEMU_PACKED
> counteracts any -mms-bitfields passed to gcc. Are there still any concerns 
> over
> this?

I'm not fantastically enthused about bitfields, but since this is a test
program and not part of QEMU proper I don't think rewriting to avoid
them is justified.

-- PMM