[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 16/18] memory: introduce memory_region_test_and_clea
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 16/18] memory: introduce memory_region_test_and_clear_dirty |
Date: |
Mon, 29 Oct 2012 15:11:41 +0100 |
This function avoids having to do two calls, one to test the dirty bit, and
other to reset it.
Signed-off-by: Juan Quintela <address@hidden>
---
memory.c | 16 ++++++++++++++++
memory.h | 18 ++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/memory.c b/memory.c
index 36bb9a5..9ddaac9 100644
--- a/memory.c
+++ b/memory.c
@@ -1078,6 +1078,22 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr
addr,
return cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1);
}
+bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr,
+ hwaddr size, unsigned client)
+{
+ bool ret;
+ assert(mr->terminates);
+ ret = cpu_physical_memory_get_dirty(mr->ram_addr + addr, size,
+ 1 << client);
+ if (ret) {
+ cpu_physical_memory_reset_dirty(mr->ram_addr + addr,
+ mr->ram_addr + addr + size,
+ 1 << client);
+ }
+ return ret;
+}
+
+
void memory_region_sync_dirty_bitmap(MemoryRegion *mr)
{
AddressSpace *as;
diff --git a/memory.h b/memory.h
index 9462bfd..99434d8 100644
--- a/memory.h
+++ b/memory.h
@@ -454,6 +454,24 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,
hwaddr size);
/**
+ * memory_region_test_and_clear_dirty: Check whether a range of bytes is dirty
+ * for a specified client. It clears them.
+ *
+ * Checks whether a range of bytes has been written to since the last
+ * call to memory_region_reset_dirty() with the same @client. Dirty logging
+ * must be enabled.
+ *
+ * @mr: the memory region being queried.
+ * @addr: the address (relative to the start of the region) being queried.
+ * @size: the size of the range being queried.
+ * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or
+ * %DIRTY_MEMORY_VGA.
+ */
+bool memory_region_test_and_clear_dirty(MemoryRegion *mr,
+ hwaddr addr,
+ hwaddr size,
+ unsigned client);
+/**
* memory_region_sync_dirty_bitmap: Synchronize a region's dirty bitmap with
* any external TLBs (e.g. kvm)
*
--
1.7.11.7
- Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking, (continued)
[Qemu-devel] [PATCH 08/18] migration: remove unfreeze logic, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 10/18] buffered_file: Unfold the trick to restart generating migration data, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 12/18] buffered_file: unfold buffered_append in buffered_put_buffer, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 11/18] buffered_file: don't flush on put buffer, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 18/18] ram: optimize migration bitmap walking, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 15/18] migration-fd: remove duplicate include, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 13/18] savevm: New save live migration method: pending, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 16/18] memory: introduce memory_region_test_and_clear_dirty,
Juan Quintela <=
[Qemu-devel] [PATCH 14/18] migration: include qemu-file.h, Juan Quintela, 2012/10/29
[Qemu-devel] [PATCH 17/18] ram: Use memory_region_test_and_clear_dirty, Juan Quintela, 2012/10/29
Re: [Qemu-devel] [PATCH 00/18] Migration thread lite (20121029), Chegu Vinod, 2012/10/29