[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE |
Date: |
Mon, 29 Oct 2012 15:34:22 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 23, 2012 at 07:19:20AM +1000, Richard Henderson wrote:
> On 2012-10-22 15:59, Aurelien Jarno wrote:
> > Yes, this is a know fact that this libc function doesn't have a
> > prototype (for instance in the manpage), that said it exists and at
> > least on x32 it's actually a wrapper doing things.
> >
> > That's why I think it's better to use it than doing the syscall
> > directly.
>
> Well, we know that arch_prctl is not a wrapper for x86_64. And x32
> will never be a concern for qemu. But I guess I can change this if
> you really really insist.
>
My point here is that arch_prctl might be a wrapper for x86_64 at some
point, so it's better to do it properly now, and not to have to change
it latter.
In order to avoid one more round trip for a new version of the patch, I
have applied it doing this small changes.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net