[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb |
|
Date: |
Tue, 30 Oct 2012 07:34:26 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 |
Hi,
> + uhci_devname[sizeof(uhci_devname) - 2] = ((char)'1') + i;
snprintf(devname, sizeof(devname), "...%d", i) is more readable.
> + qdev_prop_set_string(usb_qdev, "masterbus", "ich9-usb-bus.0");
Any reason why you rename the usb bus?
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v1 05/13] pc, pc_piix: split out pc nic initialization, (continued)
- [Qemu-devel] [PATCH v1 03/13] blockdev: Introduce QEMUMachine->default_drive_if, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 06/13] pc: Move ioapic_init() from pc_piix.c to pc.c, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 04/13] blockdev: Introduce IF_AHCI, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 08/13] q35: Suppress SMM BIOS initialization under KVM, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 10/13] Add a fallback bios file search, if -L fails., Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb, Jason Baron, 2012/10/29
- Re: [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb,
Gerd Hoffmann <=
[Qemu-devel] [PATCH v1 09/13] q35: Add kvmclock support, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 11/13] q35: automatically load the q35 dsdt table, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 13/13] Fixup q35/ich9 Licenses, Jason Baron, 2012/10/29