Re: [Qemu-devel] [PATCH v1 01/13] pc/piix_pci: factor out smram/pam logic

[Andreas Färber]

Am 30.10.2012 20:07, schrieb Anthony Liguori:
> Jason Baron <address@hidden> writes:
> 
>> From: Isaku Yamahata <address@hidden>
>>
>> Factor out smram/pam logic for later use.
>> Which will be used by q35 too.
>>
>> address@hidden: changes for updated memory API]
>> Signed-off-by: Isaku Yamahata <address@hidden>
>> Signed-off-by: Jason Baron <address@hidden>
> 
> This is really not the right approach to solving this problem.
> 
> "pam" is not a device.
> 
> Instead, the common bits here are essentially the northbridge logic.
> That's what we should model here.
> 
> It's pretty simple actually.  Just throw this all into a device where
> the memory regions are owned by the device.  But also make the device
> own creation of all RAM (not just the areas controlled by PAM).
> 
> Then embed the northbridge into the i440fx and q35.

Anthony/Wanpeng, any update on i440fx? Haven't heard of it since we
finally merged the PCI host bridge stuff for v1.2...

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg