[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset em
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator |
Date: |
Wed, 31 Oct 2012 12:04:58 +0200 |
On Tue, Oct 30, 2012 at 02:18:02PM -0500, Anthony Liguori wrote:
> Jason Baron <address@hidden> writes:
>
> > From: Isaku Yamahata <address@hidden>
> >
> > pc q35 based chipset emulator to support pci express natively. Based on
> > Anthony Liguori's suggestion, the machine name is 'q35-next', with an alias
> > of 'q35'. At this point, there are no compatibility guarantees. When the
> > chipset stabilizes more, we will begin to version the machine names.
> >
> > Major features which still need to be added:
> >
> > -Migration support (mostly around ahci)
> > -ACPI hotplug support (pcie hotplug support is working)
> > -Passthrough support
> >
> > Signed-off-by: Isaku Yamahata <address@hidden>
> > Signed-off-by: Jason Baron <address@hidden>
> > ---
> > hw/i386/Makefile.objs | 2 +-
> > hw/pc.h | 2 +
> > hw/pc_piix.c | 4 +-
> > hw/pc_q35.c | 326
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> > hw/pci_ids.h | 2 +
> > hw/q35.c | 315
> > +++++++++++++++++++++++++++++++++++++++++++++++
> > hw/q35.h | 161 ++++++++++++++++++++++++
> > 7 files changed, 809 insertions(+), 3 deletions(-)
> > create mode 100644 hw/pc_q35.c
> > create mode 100644 hw/q35.c
> > create mode 100644 hw/q35.h
> >
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index 693bd18..469b127 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -7,7 +7,7 @@ obj-y += debugcon.o multiboot.o
> > obj-y += pc_piix.o
> > obj-y += pc_sysfw.o
> > obj-y += pam.o
> > -obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o
> > +obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o q35.o pc_q35.o
>
> This shouldn't be here. It should be in hw/Makefile.objs.
>
> This is not target specific code.
What about acpi_ich9.o lpc_ich9.o smbus_ich9.o? Should it move to Makefile.objs
too?
How is this different from pc_piix?
--
MST
- [Qemu-devel] [PATCH v1 10/13] Add a fallback bios file search, if -L fails., (continued)
[Qemu-devel] [PATCH v1 09/13] q35: Add kvmclock support, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 11/13] q35: automatically load the q35 dsdt table, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator, Jason Baron, 2012/10/29
[Qemu-devel] [PATCH v1 13/13] Fixup q35/ich9 Licenses, Jason Baron, 2012/10/29
Re: [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree, Anthony Liguori, 2012/10/30