qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/2] uhci: Don't crash on device disconnect


From: Hans de Goede
Subject: [Qemu-devel] [PATCH 0/2] uhci: Don't crash on device disconnect
Date: Wed, 31 Oct 2012 12:54:35 +0100

My recent uhci cleanup series has introduced a regression, where
qemu sometimes crashes on a device disconnect. The problem is that
the uhci code never checked for a device not / no longer existing, instead
it was relying on usb_handle_packet accepting a NULL device.

But since we now pass usb_handle_packet q->ep->dev, rather then just
a local dev variable, we crash as q->ep == NULL due to the device no longer
existing.

This patch-set fixes this. Note that this patch-set also improves over
the old behavior were we would:
1) create a queue for the device/ep
2) create an async for the packet
3) have usb_handle_packet fail
4) destroy the async
5) wait for the queue to be idle for 32 frames
6) destroy the queue

Which was rather sub-optimal.

Regards,

Hans



reply via email to

[Prev in Thread] Current Thread [Next in Thread]