Re: [Qemu-devel] 64-on-32 TCG broken

[Peter Maydell]

On 31 October 2012 15:01, Paolo Bonzini <address@hidden> wrote:
> Thanks!  In general, do not rebase a branch unless you were able to test
> the rebase fully.  Use "git merge" instead.  This does not apply to
> people without commit access (unless they use pull requests---perhaps we
> should use them more), but it is easy for you.
>
> If you hadn't rebased the series, "git bisect" would have pointed out
> that the original series worked, and that the merge was the problem.

I don't think this actually gains us anything, because we've still
checked broken code into master, whether it was via a rebase or a
merge. The correct answer is "test your commits before sending them",
surely?

-- PMM