Re: [Qemu-devel] [PATCH] target-alpha: Use TCG_CALL_NO_WG

[Aurelien Jarno]

On Wed, Oct 31, 2012 at 10:30:55AM +1100, Richard Henderson wrote:
> Mark helper functions that raise exceptions, but otherwise do not
> change TCG register state, with TCG_CALL_NO_WG.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target-alpha/helper.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/target-alpha/helper.h b/target-alpha/helper.h
> index 162816f..dd55f89 100644
> --- a/target-alpha/helper.h
> +++ b/target-alpha/helper.h
> @@ -3,12 +3,12 @@
>  DEF_HELPER_3(excp, noreturn, env, int, int)
>  DEF_HELPER_FLAGS_1(load_pcc, TCG_CALL_NO_RWG_SE, i64, env)
>  
> -DEF_HELPER_3(addqv, i64, env, i64, i64)
> -DEF_HELPER_3(addlv, i64, env, i64, i64)
> -DEF_HELPER_3(subqv, i64, env, i64, i64)
> -DEF_HELPER_3(sublv, i64, env, i64, i64)
> -DEF_HELPER_3(mullv, i64, env, i64, i64)
> -DEF_HELPER_3(mulqv, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(addqv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(addlv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(subqv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(sublv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(mullv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(mulqv, TCG_CALL_NO_WG, i64, env, i64, i64)
>  DEF_HELPER_FLAGS_2(umulh, TCG_CALL_NO_RWG_SE, i64, i64, i64)
>  
>  DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64)
> @@ -92,11 +92,11 @@ DEF_HELPER_FLAGS_2(setroundmode, TCG_CALL_NO_RWG, void, 
> env, i32)
>  DEF_HELPER_FLAGS_2(setflushzero, TCG_CALL_NO_RWG, void, env, i32)
>  DEF_HELPER_FLAGS_1(fp_exc_clear, TCG_CALL_NO_RWG, void, env)
>  DEF_HELPER_FLAGS_1(fp_exc_get, TCG_CALL_NO_RWG_SE, i32, env)
> -DEF_HELPER_3(fp_exc_raise, void, env, i32, i32)
> -DEF_HELPER_3(fp_exc_raise_s, void, env, i32, i32)
> +DEF_HELPER_FLAGS_3(fp_exc_raise, TCG_CALL_NO_WG, void, env, i32, i32)
> +DEF_HELPER_FLAGS_3(fp_exc_raise_s, TCG_CALL_NO_WG, void, env, i32, i32)
>  
> -DEF_HELPER_2(ieee_input, void, env, i64)
> -DEF_HELPER_2(ieee_input_cmp, void, env, i64)
> +DEF_HELPER_FLAGS_2(ieee_input, TCG_CALL_NO_WG, void, env, i64)
> +DEF_HELPER_FLAGS_2(ieee_input_cmp, TCG_CALL_NO_WG, void, env, i64)
>  
>  #if !defined (CONFIG_USER_ONLY)
>  DEF_HELPER_2(hw_ret, void, env, i64)

Reviewed-by: Aurelien Jarno <address@hidden>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net