qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions
Date: Thu, 01 Nov 2012 11:08:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121026 Thunderbird/10.0.10

On 10/31/12 13:47, Hans de Goede wrote:
> +    /*
> +     * If we had leftover packets the hcd driver will have cancelled them
> +     * and usb_combined_packet_cancel has already freed combined!
> +     */
> +    if (state != leftover) {
> +        g_free(combined);
> +    }

This calls for reference-counting USBCombinedPacket IMHO.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]