Re: [Qemu-devel] [PATCH v3 24/35] postcopy outgoing: add -p option to migrate command

[Eric Blake]

On 10/30/2012 02:33 AM, Isaku Yamahata wrote:
> Added -p option to migrate command for postcopy mode and
> introduce postcopy parameter for migration to indicate that postcopy mode
> is enabled.
> 
> Signed-off-by: Isaku Yamahata <address@hidden>

> diff --git a/qapi-schema.json b/qapi-schema.json
> index c615ee2..c969e5a 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2094,7 +2094,8 @@
>  # Since: 0.14.0
>  ##
>  { 'command': 'migrate',
> -  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' } 
> }
> +  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' ,
> +           '*postcopy': 'bool'} }

You should also document this new variable a few lines earlier,
something like:

# @postcopy: #optional if true, perform a postcopy migration
#            (since 1.3, default false)

Also, I have to wonder if this should go through
migrate-set-capabilities rather than adding a new field to 'migrate'.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature