[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to d
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to disable background transfer |
Date: |
Thu, 01 Nov 2012 13:56:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
On 10/30/2012 02:33 AM, Isaku Yamahata wrote:
> This is for benchmark purpose
>
> Signed-off-by: Isaku Yamahata <address@hidden>
> +++ b/qapi-schema.json
> @@ -2095,7 +2095,7 @@
> ##
> { 'command': 'migrate',
> 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' ,
> - '*postcopy': 'bool'} }
> + '*postcopy': 'bool', '*nobg': 'bool'} }
Again, document this option above, and mention that it was introduced in
1.3. In QMP, we prefer easier-to-read strings, I would consider naming
it 'background' with a default of true, where you pass false to get the
new behavior, instead of 'nobg' with a default of false and causing
double-negative logic.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 26/35] postcopy/outgoing: add -n options to disable background transfer,
Eric Blake <=