[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t |
Date: |
Fri, 02 Nov 2012 15:49:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto:
> Using appropriate types for variables is a good thing :). All users
> simply do sizeof(MyType) and the value is passed to a memory allocator,
> it should be size_t.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qemu-aio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-aio.h b/qemu-aio.h
> index 1b7eb6e..111b0b3 100644
> --- a/qemu-aio.h
> +++ b/qemu-aio.h
> @@ -23,7 +23,7 @@ typedef void BlockDriverCompletionFunc(void *opaque, int
> ret);
>
> typedef struct AIOPool {
> void (*cancel)(BlockDriverAIOCB *acb);
> - int aiocb_size;
> + size_t aiocb_size;
> BlockDriverAIOCB *free_aiocb;
> } AIOPool;
>
>
Reviewed-by: Paolo Bonzini <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t,
Paolo Bonzini <=