Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

[Paolo Bonzini]

Il 03/11/2012 15:19, Paolo Bonzini ha scritto:
> Il 03/11/2012 12:50, Blue Swirl ha scritto:
>> I'm still getting problems with Clang on Linux:
>>
>>   CC    qemu-sockets.o
>> /src/qemu/qemu-sockets.c:64:12: error: function
>> 'default_monitor_get_fd' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_monitor_get_fd(Monitor *mon, const char *name, Error 
>> **errp)
>>            ^
>> /src/qemu/qemu-sockets.c:73:12: error: function
>> 'default_qemu_set_fd_handler2' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_qemu_set_fd_handler2(int fd,
>>            ^
>> 2 errors generated.
>>
>> Perhaps the weak magic isn't so great after all.
>>
> 
> It's a clang bug.  The error should be suppressed, since the function is
> used with the weak alias.
> 
> Or try if adding "|| defined __clang__" to compiler.h fixes it.

Other possible fixes include adding "inline" to the declarations, or of
course -Wno-unneeded-internal-declaration.

Paolo