[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches. |
Date: |
Sat, 3 Nov 2012 15:26:00 +0000 |
On Sat, Nov 3, 2012 at 2:19 PM, Paolo Bonzini <address@hidden> wrote:
> Il 03/11/2012 12:50, Blue Swirl ha scritto:
>> I'm still getting problems with Clang on Linux:
>>
>> CC qemu-sockets.o
>> /src/qemu/qemu-sockets.c:64:12: error: function
>> 'default_monitor_get_fd' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_monitor_get_fd(Monitor *mon, const char *name, Error
>> **errp)
>> ^
>> /src/qemu/qemu-sockets.c:73:12: error: function
>> 'default_qemu_set_fd_handler2' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_qemu_set_fd_handler2(int fd,
>> ^
>> 2 errors generated.
>>
>> Perhaps the weak magic isn't so great after all.
>>
>
> It's a clang bug. The error should be suppressed, since the function is
> used with the weak alias.
>
> Or try if adding "|| defined __clang__" to compiler.h fixes it.
It does. Maybe __APPLE__ should be replaced by __clang__, or can the
problem also occur with GCC on Apple systems?
>
> Paolo
- [Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references, (continued)
- [Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork, Paolo Bonzini, 2012/11/02
- [Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm, Paolo Bonzini, 2012/11/02
- Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches., Peter Maydell, 2012/11/02