Re: [Qemu-devel] [PATCH] Fix out-of-tree and cross compile builds for pixman

[Blue Swirl]

On Sat, Nov 3, 2012 at 7:02 PM, Peter Maydell <address@hidden> wrote:
> On 3 November 2012 19:47, Blue Swirl <address@hidden> wrote:
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -122,7 +122,7 @@ subdir-pixman: pixman/Makefile
>>         $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pixman V="$(V)" 
>> all,)
>>
>>  pixman/Makefile: $(SRC_PATH)/pixman/configure
>> -       (cd pixman; $(SRC_PATH)/pixman/configure --disable-shared 
>> --enable-static)
>> +       (cd pixman; CC=$(CC) LD=$(LD) AR=$(AR) NM=$(NM) RANLIB=$(RANLIB) 
>> $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
>
> Not tested, but aren't there quoting issues here if you're
> building with --cc='ccache gcc' ?

Yes. Also configure fails because the variables are not expanded and
directory pixman/pixman does not exist. Funny how it worked earlier.

>
> -- PMM