qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] kvmvapic: Fix TB invalidation after instruction


From: Hervé Poussineau
Subject: Re: [Qemu-devel] [PATCH] kvmvapic: Fix TB invalidation after instruction patching
Date: Sun, 04 Nov 2012 08:51:19 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

Jan Kiszka a écrit :
> From: Jan Kiszka <address@hidden>
>
> Since 0b57e287, cpu_memory_rw_debug already triggers a TB invalidation.
> As it doesn't (and cannot) set is_cpu_write_access=1 but "consumes" the
> currently executed TB, the tb_invalidate_phys_page_range call from
> patch_instruction didn't work anymore.
>
> Fix this by open-coding the required bits to restore the CPU state from
> the current TB position before patching and resume execution on the
> patched instruction afterward.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>

Tested-by: Hervé Poussineau <address@hidden>

However, I had to initialize current_pc, current_cs_base and current_flags to 0 to prevent uninitialized warning.
(GCC 4.7.1, KVM disabled by configure)

Regards,

Hervé



reply via email to

[Prev in Thread] Current Thread [Next in Thread]