[Qemu-devel] Crash on Windows XP startup

[Gerhard Wiesinger]

Hello,

I bisected down a Windows XP startup crash to the following commit:

0b57e287138728f72d88b06e69b970c5d745c44a is the first bad commit
commit 0b57e287138728f72d88b06e69b970c5d745c44a
Author: David Gibson <address@hidden>
Date:   Mon Sep 10 12:30:57 2012 +1000

Reproduceable on qemu HEAD and by commenting out the refactored patch 
into a function.

How to proceed?

Ciao,
Gerhard

diff --git a/exec.c b/exec.c
index af94f9c..a937882 100644
--- a/exec.c
+++ b/exec.c
@@ -3501,7 +3501,7 @@ void cpu_physical_memory_write_rom(hwaddr addr,
             /* ROM/RAM case */
             ptr = qemu_get_ram_ptr(addr1);
             memcpy(ptr, buf, l);
-            invalidate_and_set_dirty(addr1, l);
+            //invalidate_and_set_dirty(addr1, l);
             qemu_put_ram_ptr(ptr);
         }
         len -= l;