Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC

[BALATON Zoltan]

On Thu, 8 Nov 2012, Gerd Hoffmann wrote:
> > I think this is fixing this at the wrong level. Either we
> > should require that drivers (in this case vmware_vga.c)
> > must not call dpy_gfx_update() with out of range values,
> > or we should do the clipping in the console.c layer, but
> > I don't think requiring every UI backend to clip is the
> > right thing. Anthony?
>
> Agree.  IMHO vmware_vga.c is at fault here and should be fixed.  We can
> add some asserts to console.[ch] to enforce this ...

Would the attached patch help?

Regards,
BALATON Zoltan

0002-vmware_vga-Clip-updates-with-negative-out-of-range-r.patch
Description: Text document