Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

[Paolo Bonzini]

Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto:
>>> 2.) Added debug code to block.c and to block/vmdk.c to verify
>>> correctness
>> Same here.  Also, please use the tracing infrastructure---a lot of the
>> debug
>> messages you're adding, though not all, are in fact already available
>> (not
>> saying the others aren't useful!)
> 
> Any chance that the patch with debug code only (after some cleaning)
> would be accepted (other modules do debug logging, too)?
> I  don't like to do useless work.
> Tracing infrastructure is quite limited to function calls only (as far
> as I saw).

No, tracing infrastructure uses function calls for tracing (messages go
into trace-events) but you can apply it to everything you want.  Use the
stderr backend to debug it.

Debug patches using traces are certainly welcome.

Paolo