|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete() to remove device from views |
| Date: | Mon, 12 Nov 2012 10:27:58 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 05/11/2012 06:38, Liu Ping Fan ha scritto:
> +void qdev_unplug_complete(DeviceState *dev, Error **errp)
> +{
> + /* isolate from mem view */
> + qdev_unmap(dev);
> + /* isolate from device tree */
> + qdev_unset_parent(dev);
> + object_unref(OBJECT(dev));
This leaks the device. I'll send a patch to fix this, please include it
in v7.
Paolo
> +}
> +
| [Prev in Thread] | Current Thread | [Next in Thread] |