[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooli
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling |
|
Date: |
Mon, 12 Nov 2012 11:42:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 12.11.2012 11:37, schrieb Paolo Bonzini:
> Il 12/11/2012 11:34, Kevin Wolf ha scritto:
>>> Note that the change from g_malloc0() to g_slice_alloc() should be safe
>>> since the freelist reuse case doesn't zero the AIOCB either.
>>
>> Of course the real reason is that all fields are set anyway.
>
> This doesn't necessarily apply for "subclasses", though. (It does for
> the reason Stefan mentioned, but it is not possible to make it apparent
> in the code).
See? I really shouldn't review code any more. :-)
Kevin