Re: [Qemu-devel] [PATCH 04/30] buffered_file: Move from using a timer to use a thread

[Paolo Bonzini]

Il 18/10/2012 09:30, Juan Quintela ha scritto:
> @@ -160,11 +162,8 @@ static int buffered_close(void *opaque)
>      if (ret >= 0) {
>          ret = ret2;
>      }
> -    qemu_del_timer(s->timer);
> -    qemu_free_timer(s->timer);
> -    g_free(s->buffer);
> -    g_free(s);
> -
> +    ret = migrate_fd_close(s->migration_state);
> +    s->complete = true;
>      return ret;

Just above these lines there is

    ret2 = migrate_fd_close(s->migration_state);

I believe the second call to migrate_fd_close should be removed.

Paolo