[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main di
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory |
|
Date: |
Mon, 12 Nov 2012 22:38:46 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost
> the same, but linux-user have the additional definitions of tswapal().
>
> This moves the linux-user file to the main directory, so the same file
> can be used by linux-user and bsd-user.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
A quick diff -u confirms that this is (still) the case. I had suggested
unifying these files long time ago when I tried fixing darwin-user, but
hit resistance in favor of having the *-users separate. I'm still in
favor of not duplicating identical code, so
Acked-by: Andreas Färber <address@hidden>
Riku, do you agree?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h), (continued)
[Qemu-devel] [PATCH 11/24] qapi/qmp-registry.c: include headers it needs, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 13/24] create qemu-types.h for struct typedefs, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 10/24] qemu-config.h: include headers it needs, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory, Eduardo Habkost, 2012/11/09
- Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory,
Andreas Färber <=
[Qemu-devel] [PATCH 17/24] qdev-properties.c: add copyright/license information, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 22/24] qdev-properties.c: separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 03/24] qemu-common.h: comment about usage rules, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 18/24] qdev: qdev_create(): use error_report() instead of hw_error(), Eduardo Habkost, 2012/11/09