[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of inte
From: |
David Gibson |
Subject: |
[Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller |
Date: |
Tue, 13 Nov 2012 13:46:49 +1100 |
Currently in the reset code for the XICS interrupt controller, we
initialize the pending_priority field to 0 (most favored, by XICS
convention). This is incorrect, since there is no pending interrupt, it
should be set to least favored - 0xff. At the moment our XICS
implementation doesn't get hurt by this edge case, but it does confuse the
upcoming kernel XICS implementation.
Signed-off-by: David Gibson <address@hidden>
---
hw/xics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xics.c b/hw/xics.c
index 1da3106..edf5833 100644
--- a/hw/xics.c
+++ b/hw/xics.c
@@ -495,7 +495,7 @@ static void xics_reset(void *opaque)
for (i = 0; i < icp->nr_servers; i++) {
icp->ss[i].xirr = 0;
- icp->ss[i].pending_priority = 0;
+ icp->ss[i].pending_priority = 0xff;
icp->ss[i].mfrr = 0xff;
/* Make all outputs are deasserted */
qemu_set_irq(icp->ss[i].output, 0);
--
1.7.10.4
[Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/12