[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete(
From: |
liu ping fan |
Subject: |
Re: [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete() to remove device from views |
Date: |
Tue, 13 Nov 2012 14:12:19 +0800 |
On Mon, Nov 12, 2012 at 5:27 PM, Paolo Bonzini <address@hidden> wrote:
> Il 05/11/2012 06:38, Liu Ping Fan ha scritto:
>> +void qdev_unplug_complete(DeviceState *dev, Error **errp)
>> +{
>> + /* isolate from mem view */
>> + qdev_unmap(dev);
>> + /* isolate from device tree */
>> + qdev_unset_parent(dev);
>> + object_unref(OBJECT(dev));
>
> This leaks the device. I'll send a patch to fix this, please include it
> in v7.
>
OK. Please CC me.
Thanks
Pingfan
> Paolo
>
>> +}
>> +
>
- [Qemu-devel] [PATCH v6 0/8] push mmio dispatch out of big lock, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 2/8] qom: apply atomic on object's refcount, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 3/8] hotplug: introduce qdev_unplug_complete() to remove device from views, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 4/8] pci: remove pci device from mem view when unplug, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 5/8] memory: introduce local lock for address space, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 6/8] memory: make mmio dispatch able to be out of biglock, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 8/8] vcpu: push mmio dispatcher out of big lock, Liu Ping Fan, 2012/11/05
- [Qemu-devel] [PATCH v6 7/8] memory: introduce tls context to trace nested mmio request issue, Liu Ping Fan, 2012/11/05
- Re: [Qemu-devel] [PATCH v6 0/8] push mmio dispatch out of big lock, Jan Kiszka, 2012/11/05