Re: [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers

[Paolo Bonzini]

Il 13/11/2012 16:51, Kevin Wolf ha scritto:
> This series has two patches that fixes current qemu_aio_flush() callers, which
> should call bdrv_drain_all() instead. The other two patches are for changing
> the coroutine request cancellation to waiting for a single request (Paolo
> didn't want to change this to bdrv_drain_all()) and removing qemu_aio_flush()
> altogether in order to avoid future misuse.
> 
> Kevin Wolf (4):
>   block: Improve bdrv_aio_co_cancel_em
>   megasas: Use bdrv_drain_all instead of qemu_aio_flush
>   qemu-io: Use bdrv_drain_all instead of qemu_aio_flush
>   aio: Get rid of qemu_aio_flush()
> 
>  async.c        |    5 -----
>  block.c        |   19 ++++++++++++++++++-
>  block/commit.c |    2 +-
>  block/mirror.c |    2 +-
>  block/stream.c |    2 +-
>  hw/megasas.c   |    2 +-
>  main-loop.c    |    5 -----
>  qemu-aio.h     |    9 ++-------
>  qemu-io.c      |    2 +-
>  9 files changed, 25 insertions(+), 23 deletions(-)
> 

Patches 2 and 3 look good.  The rest is 1.4 material, looks good but
maybe we can do something better than the ->done boolean... no ideas,
just thinking out loud, but perhaps it will come out naturally of the
AioContext/data-plane work.

Paolo