[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used i
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h |
Date: |
Wed, 14 Nov 2012 14:51:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> From: Anthony Liguori <address@hidden>
>
> Header file dependency is a frickin' nightmare right now. cpu.h tends to get
> included in our 'include everything' header files but qdev also needs to
> include
> those headers mainly for qdev-properties since it knows about CharDriverState
> and friends.
>
> We can solve this for now by splitting out qdev.h along the same lines that we
> previously split the C file. Then cpu.h just needs to include qdev-core.h
>
> hw/qdev.h is split into following new headers:
> hw/qdev-core.h
> hw/qdev-properties.h
> hw/qdev-monitor.h
>
> Signed-off-by: Anthony Liguori <address@hidden>
>
> [ehabkost: re-add DEFINE_PROP_PCI_HOST_DEVADDR, that was removed on the
> original patch (by mistake, I guess)]
> [ehabkost: kill qdev_prop_set_vlan() declaration]
> [ehabkost: moved get_fw_dev_path() comment to the original location
> (I don't know why it was moved)]
> [ehabkost: removed qdev_exists() declaration]
> [ehabkost: keep using 'QemuOpts' instead of 'struct QemuOpts', as
> qdev-core.h includes qemu-option.h]
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Yay, I made it through this patch line by line! Perfect now,
Acked-by: Andreas Färber <address@hidden>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory, (continued)
- [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 17/24] qdev-properties.c: add copyright/license information, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 22/24] qdev-properties.c: separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 03/24] qemu-common.h: comment about usage rules, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/11/09
- Re: [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h,
Andreas Färber <=
- [Qemu-devel] [PATCH 18/24] qdev: qdev_create(): use error_report() instead of hw_error(), Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 08/24] vnc-palette.h: include <stdbool.h>, Eduardo Habkost, 2012/11/09
[Qemu-devel] [PATCH 09/24] ui/vnc-pallete.c: include headers it needs, Eduardo Habkost, 2012/11/09