[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h |
Date: |
Wed, 14 Nov 2012 23:42:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> I don't know why it was including it, as I don't see any code that
> depends on anything from qemu-common.h.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> qlist.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/qlist.h b/qlist.h
> index ae776f9..7408947 100644
> --- a/qlist.h
> +++ b/qlist.h
> @@ -15,7 +15,6 @@
>
> #include "qobject.h"
> #include "qemu-queue.h"
> -#include "qemu-common.h"
> #include "qemu-queue.h"
>
> typedef struct QListEntry {
CC qga/channel-posix.o
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c: In function
‘ga_channel_open’:
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error: implicit
declaration of function ‘exit’ [-Werror=implicit-function-declaration]
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:13: error:
incompatible implicit declaration of built-in function ‘exit’ [-Werror]
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: error:
‘EXIT_FAILURE’ undeclared (first use in this function)
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:141:18: note: each
undeclared identifier is reported only once for each function it appears in
/home/andreas/QEMU/qemu-rcar/qga/channel-posix.c:163:13: error:
incompatible implicit declaration of built-in function ‘exit’ [-Werror]
cc1: all warnings being treated as errors
make: *** [qga/channel-posix.o] Fehler 1
Sounds related to not doing qemu-stdio.h...
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/24] CPU DeviceState v7, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 20/24] qdev: add weak aliases for vmstate handling on qdev.c, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 23/24] include qdev code into *-user, too, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 24/24] qom: make CPU a child of DeviceState, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 14/24] sysemu.h: include qemu-types.h instead of qemu-common.h, Eduardo Habkost, 2012/11/09