Re: [Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly

[Peter Maydell]

On 16 November 2012 10:23, Paolo Bonzini <address@hidden> wrote:
> Il 16/11/2012 06:05, Wenchao Xia ha scritto:
>> -     $(MAKE) -C tests/tcg clean
>> +     MAKEFILES=./tests/Makefile $(MAKE) check-clean
>
> What is MAKEFILES?

make uses it as a list of additional makefiles to be read,
as if they were 'include'd at the start of whatever makefile
it actually reads. This is almost certainly not what is
meant here, because this $(MAKE) invocation will reread
the makefile we're currently executing, prepend tests/Makefile
(gratuitously since our Makefile explicitly includes it
anyway) and then invoke the check-clean target, which
happens to work OK because tests/Makefile expects to be
included rather than standalone.

If this roundabout approach is intentional and not accidental
it needs a comment explaining why it's needed.

-- PMM