Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory

[Blue Swirl]

On Mon, Nov 12, 2012 at 9:38 PM, Andreas Färber <address@hidden> wrote:
> Am 09.11.2012 15:56, schrieb Eduardo Habkost:
>> The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost
>> the same, but linux-user have the additional definitions of tswapal().
>>
>> This moves the linux-user file to the main directory, so the same file
>> can be used by linux-user and bsd-user.
>>
>> Signed-off-by: Eduardo Habkost <address@hidden>
>
> A quick diff -u confirms that this is (still) the case. I had suggested
> unifying these files long time ago when I tried fixing darwin-user, but
> hit resistance in favor of having the *-users separate. I'm still in
> favor of not duplicating identical code, so

The problem in general with merging user emulator code is that the
changes may cause regressions since there are subtle differences. In
this specific case it should be OK.

>
> Acked-by: Andreas Färber <address@hidden>
>
> Riku, do you agree?
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg