Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

[Paolo Bonzini]

Il 17/11/2012 19:47, Alex Horn ha scritto:
> I have attached a patch for the most recent version of the file
> hw/mc146818rtc.c [1]. The patch also features a functional test which
> executes through the QTest framework.
> 
> I would appreciate your thoughts on this.
> 
> [1]
> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/mc146818rtc.c;h=98839f278d93452d071054e2a017b3d909b45ab2;hb=9cb535fe4ef08b01e583ec955767a0899ff79afe#l563
> 
> ** Patch added: "register_b_set_flag.patch"
>    
> https://bugs.launchpad.net/qemu/+bug/1080086/+attachment/3436808/+files/register_b_set_flag.patch
> 

Hi Alex, the patch is almost good for inclusion.  I'd ask for two
changes: 1) please test == 0, not != REG_B_SET; 2) please leave the
fuzzing test last, because it may leave some registers in an undefined
state.

Paolo