Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs

[Wenchao Xia]

于 2012-11-16 19:12, Paolo Bonzini 写道:
> Il 16/11/2012 11:58, Wenchao Xia ha scritto:
> > > >     Sub Makefile may need qapi generated files, so move them to
> > > > Makefile.objs,
> > > > In this way Makfile.objs control file auto generation.
> > >
> > > No objection in principle, but why are you doing this?  Does it fix
> > > anything?
> >
> >    It seems tools or block objects files are depending on qapi files,
>
> Yes, block files are.
>
> > and libqblock needs tools. So without it out of tree build of libqblock
> > would fail.
>
> The effect of this patch is to include the rules in libqblock's own
> Makefile.
>
> libqblock indeed needs to compile these files to .lo.  However,
> regeneration of the C source code and header shouldn't be needed there.
>   I think you're missing a dependency in the toplevel Makefile's
> "libqblock.la" rule.
  yes, I'll try avoid generation of those C files in sub directory.
Still moving generation rules all into Makefile.obs seems right to me.

> By the way, do not name that rule "libqblock.la".  It doesn't build
> libqblock.la, it builds libqblock/libqblock.la.  Instead, name it
> subdir-libqblock.
  OK.

> Paolo


--
Best Regards

Wenchao Xia