[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized |
Date: |
Mon, 19 Nov 2012 09:25:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 17/11/2012 16:20, Peter Lieven ha scritto:
> Without any complex checks we can't assume that an
> iscsi target is initialized to zero.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/iscsi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index eb586cb..d685f20 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -991,6 +991,11 @@ out:
> return ret;
> }
>
> +static int iscsi_has_zero_init(BlockDriverState *bs)
> +{
> + return 0;
> +}
> +
> static QEMUOptionParameter iscsi_create_options[] = {
> {
> .name = BLOCK_OPT_SIZE,
> @@ -1017,6 +1022,7 @@ static BlockDriver bdrv_iscsi = {
> .bdrv_aio_flush = iscsi_aio_flush,
>
> .bdrv_aio_discard = iscsi_aio_discard,
> + .bdrv_has_zero_init = iscsi_has_zero_init,
>
> #ifdef __linux__
> .bdrv_ioctl = iscsi_ioctl,
>
Applied to scsi-next branch.
Paolo