[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off perform
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] virtio-blk: add x-data-plane=on|off performance feature |
Date: |
Mon, 19 Nov 2012 11:51:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 19/11/2012 11:38, Kevin Wolf ha scritto:
> Am 16.11.2012 07:22, schrieb Stefan Hajnoczi:
>> On Thu, Nov 15, 2012 at 10:08 PM, Anthony Liguori <address@hidden> wrote:
>>> Stefan Hajnoczi <address@hidden> writes:
>>>
>>>> The virtio-blk-data-plane feature is easy to integrate into
>>>> hw/virtio-blk.c. The data plane can be started and stopped similar to
>>>> vhost-net.
>>>>
>>>> Users can take advantage of the virtio-blk-data-plane feature using the
>>>> new -device virtio-blk-pci,x-data-plane=on property.
>>>
>>> I don't think this should be a property of virtio-blk-pci but rather a
>>> separate device.
>>
>> The hw/virtio-blk.c code still needs to be used since
>> hw/dataplane/virtio-blk.c is only a subset of virtio-blk.
>>
>> So we're talking about adding a new virtio-blk-data-plane-pci device
>> type to hw/virtio-pci.c?
>
> A new device sounds wrong to me, it's the very same thing from a guest
> perspective. Which makes me wonder if in the final version it shouldn't
> be a -blockdev option rather than a -device one...
In the final version it shouldn't be an option at all. :)
Paolo
[Qemu-devel] [PATCH 6/7] dataplane: add virtio-blk data plane code, Stefan Hajnoczi, 2012/11/15
Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Asias He, 2012/11/20
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/11/20
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/11/20
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Asias He, 2012/11/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Asias He, 2012/11/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/11/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Asias He, 2012/11/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/11/22