Re: [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property definition

[Stefan Hajnoczi]

On Thu, Nov 15, 2012 at 01:12:14PM +1100, David Gibson wrote:
> For the virtio-blk device (via virtio-pci) the property "config-wce" is
> defined in two places.  First, it's defined from the
> DEFINE_VIRTIO_BLK_FEATURES macro, second it's defined directly in
> virtio-pci, just two lines above the call to that macro.
> 
> The direct definition in virtio-pci.c is broken, since it operates on the
> 'config_wce' field of VirtIOBlkConf, which is never used anywhere else.
> Therefore, this patch removes both the extra property definition and the
> redundant field it works on.
> 
> Cc: Kevin Wolf <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Cc: Paul 'Rusty' Russell <address@hidden>
> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  hw/virtio-blk.h |    1 -
>  hw/virtio-pci.c |    1 -
>  2 files changed, 2 deletions(-)

Thanks, applied to the block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan