Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

[Peter Maydell]

On 19 November 2012 13:14, Alexander Graf <address@hidden> wrote:
>
> On 13.11.2012, at 13:11, Christian Borntraeger wrote:
>
>> From: Heinz Graalfs <address@hidden>
>>
>> The global variable 'ram_size' is hidden by the local variable
>> declaration in s390_init()
>
> That's the point of Eduardo's patch, no? Or do we need access
> to the global to change its value afterwards?

The function later does:
    /* lets propagate the changed ram size into the global variable. */
    ram_size = my_ram_size;

which frankly I think is pretty nasty but then we've never
had a very good mechanism for specifying board-specific
restrictions around the memory size.

-- PMM