qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit tran


From: Alexander Graf
Subject: Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux
Date: Tue, 20 Nov 2012 15:37:50 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120306 Thunderbird/10.0.3

On 11/20/2012 02:55 PM, Christoffer Dall wrote:
On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf<address@hidden>  wrote:
On 11/20/2012 02:31 PM, Peter Maydell wrote:
ARM Linux (like x86-64 Linux) can use transparent hugepages for
KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN
accordingly.

Signed-off-by: Peter Maydell<address@hidden>
---
   oslib-posix.c |    2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/oslib-posix.c b/oslib-posix.c
index 9db9c3d..d25b52a 100644
--- a/oslib-posix.c
+++ b/oslib-posix.c
@@ -35,7 +35,7 @@
   extern int daemon(int, int);
   #endif

-#if defined(__linux__)&&   defined(__x86_64__)
+#if defined(__linux__)&&   (defined(__x86_64__) || defined(__arm__))

Why not just drop the arch specific bit?


other archs have other alignment requirements, iirc.

Ah, sorry, missed the rest of the lines around this one :). Yeah, should be ok then.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]