Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols

[Stefan Hajnoczi]

On Tue, Nov 20, 2012 at 04:34:17PM +0100, Stefan Hajnoczi wrote:
> It's poor symbol hygiene to provide a global symbols that collide with a
> common library like libuuid.  If QEMU links against a shared library
> that depends on uuid_generate() it can end up calling our stub version
> of the function.
> 
> This exact scenario happened with GlusterFS libgfapi.so, which depends
> on libglusterfs.so's uuid_generate().
> 
> Scope the uuid stubs for vdi.c only and avoid affecting other shared
> objects.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  block/vdi.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Thanks, applied to the block tree:
https://github.com/stefanha/qemu/commits/block

Stefan