[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] use int64_t for return values from rbd instead
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 3/5] use int64_t for return values from rbd instead of int |
Date: |
Wed, 21 Nov 2012 11:12:30 +0100 |
From: Stefan Priebe <address@hidden>
rbd / rados tends to return pretty often length of writes
or discarded blocks. These values might be bigger than int.
The steps to reproduce are:
mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends
a discard. Important is that you use scsi-hd and set
discard_granularity=512. Otherwise rbd disabled discard support.
Signed-off-by: Stefan Priebe <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 0aaacaf..f3becc7 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -69,7 +69,7 @@ typedef enum {
typedef struct RBDAIOCB {
BlockDriverAIOCB common;
QEMUBH *bh;
- int ret;
+ int64_t ret;
QEMUIOVector *qiov;
char *bounce;
RBDAIOCmd cmd;
@@ -86,7 +86,7 @@ typedef struct RADOSCB {
int done;
int64_t size;
char *buf;
- int ret;
+ int64_t ret;
} RADOSCB;
#define RBD_FD_READ 0
--
1.8.0
- [Qemu-devel] [PULL 1.3-rc1 0/5] Block patches for QEMU 1.3-rc1, Stefan Hajnoczi, 2012/11/21
- [Qemu-devel] [PATCH 2/5] vdi: don't override libuuid symbols, Stefan Hajnoczi, 2012/11/21
- [Qemu-devel] [PATCH 4/5] ide: Fix crash with too long PRD, Stefan Hajnoczi, 2012/11/21
- [Qemu-devel] [PATCH 1/5] block: add bdrv_reopen() support for raw hdev, floppy, and cdrom, Stefan Hajnoczi, 2012/11/21
- [Qemu-devel] [PATCH 3/5] use int64_t for return values from rbd instead of int,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 5/5] ide: Fix status register after short PRDs, Stefan Hajnoczi, 2012/11/21
- Re: [Qemu-devel] [PULL 1.3-rc1 0/5] Block patches for QEMU 1.3-rc1, Anthony Liguori, 2012/11/26