qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead


From: Stefan Priebe - Profihost AG
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Thu, 22 Nov 2012 09:23:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2

Am 21.11.2012 23:32, schrieb Peter Maydell:
On 21 November 2012 17:03, Stefan Weil <address@hidden> wrote:
Why do you use int64_t instead of off_t?
If the value is related to file sizes, off_t would be a good choice.

Looking at the librbd API (which is what the size and ret
values come from), it uses size_t and ssize_t for these.
So I think probably ssize_t is the right type for ret
(and size) in our structs here.

This sounds reasonable but does ssize_t support negative values? For error values.

Greets,
Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]