Re: [Qemu-devel] [PATCH for 1.3 v2] block: Fix regression for MinGW (assertion caused by short string)

[Stefan Hajnoczi]

On Thu, Nov 22, 2012 at 07:25:48AM +0100, Stefan Weil wrote:
> The local string tmp_filename is passed to function get_tmp_filename
> which expects a string with minimum size MAX_PATH for w32 hosts.
> 
> MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short.
> 
> Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this
> regression.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> v2: Added TODO comment as suggested by Stefan Hajnoczi.
> 
> Hi Anthony, hi Blue,
> 
> this fix is needed for 1.3 to avoid a fatal assertion on Windows.
> As discussed on qemu-devel, it is a minimal solution and can be
> replaced by a better one after 1.3.
> 
> Please commit it to git master.
> 
> Regards
> Stefan
> 
> 
>  block.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>