[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0
From: |
Christian Borntraeger |
Subject: |
[Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0 |
Date: |
Thu, 22 Nov 2012 21:02:56 +0100 |
Lets make the comment regarding IF_IDE more precise
why it must be 0.
Signed-off-by: Christian Borntraeger <address@hidden>
---
blockdev.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/blockdev.h b/blockdev.h
index 1c9ca6a..d73d552 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -19,7 +19,11 @@ void blockdev_auto_del(BlockDriverState *bs);
typedef enum {
IF_DEFAULT = -1, /* for use with drive_add() only */
- IF_IDE, /* machines without block_default_type get 0 */
+ /*
+ * IF_IDE must be zero, because we want QEMUMachine member
+ * block_default_type to default-initialize to IF_IDE
+ */
+ IF_IDE = 0,
IF_NONE,
IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
IF_COUNT
--
1.7.9.5
- [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Christian Borntraeger, 2012/11/20
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Alexander Graf, 2012/11/20
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Igor Mitsyanko, 2012/11/21
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Markus Armbruster, 2012/11/22
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Christian Borntraeger, 2012/11/22
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Markus Armbruster, 2012/11/22
- [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Christian Borntraeger, 2012/11/22
- [Qemu-devel] [PATCH 1/2] block: simply default_drive, Christian Borntraeger, 2012/11/22
- [Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Stefan Hajnoczi, 2012/11/23
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Markus Armbruster, 2012/11/23
- Re: [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface, Stefan Hajnoczi, 2012/11/23
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Stefan Hajnoczi, 2012/11/22
- Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Markus Armbruster, 2012/11/22
Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine, Stefan Hajnoczi, 2012/11/22