[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no argument
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no argument |
Date: |
Fri, 23 Nov 2012 07:49:41 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 20, 2012 at 07:11:21AM -0700, Bruce Rogers wrote:
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
>
> Signed-off-by: Bruce Rogers <address@hidden>
> ---
> qemu-options.hx | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..fbcf079 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> ETEXI
>
> HXCOMM Deprecated by -machine accel=tcg property
> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by kvm-pit driver properties
> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "",
> QEMU_ARCH_I386)
> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> --
> 1.7.7
Anthony, please consider this patch for QEMU 1.3-rc1. Without it the
deprecated qemu-kvm options don't work!
Reviewed-by: Stefan Hajnoczi <address@hidden>
Stefan
Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no argument,
Stefan Hajnoczi <=