[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interf
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interface |
Date: |
Fri, 23 Nov 2012 13:11:08 +0100 |
On Thu, 22 Nov 2012 15:50:51 +0100
address@hidden wrote:
> +static void virtiopci_class_init(ObjectClass *oc, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(oc);
> + PCIDeviceClass *pc = PCI_DEVICE_CLASS(oc);
> +
> + pc->init = virtiopci_qdev_init;
> + pc->exit = virtio_exit_pci;
Doesn't the exit function need to be symmetric to the init function?
> + pc->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
> + pc->revision = VIRTIO_PCI_ABI_VERSION;
> + pc->class_id = PCI_CLASS_OTHERS;
> + /* TODO : Add the correct device information below */
> + /* pc->exit =
> + * pc->device_id =
> + * pc->subsystem_vendor_id =
> + * pc->subsystem_id =
> + * dc->reset =
> + * dc->vmsd =
> + */
> + dc->props = virtiopci_properties;
> + dc->desc = "virtio-pci transport.";
> +}
Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interface, Anthony Liguori, 2012/11/26
[Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus., fred . konrad, 2012/11/22