Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interface

[Konrad Frederic]

On 23/11/2012 13:34, Peter Maydell wrote:
> On 23 November 2012 12:29, Stefan Hajnoczi<address@hidden>  wrote:
> > On Thu, Nov 22, 2012 at 03:50:51PM +0100, address@hidden wrote:
> > > +static const struct VirtioBusInfo virtio_bus_info = {
> > > +    .init_cb = virtio_pci_init_cb,
> > > +    .exit_cb = virtio_pci_exit_cb,
> > > +
> > > +    .virtio_bindings = {
> > Eventually VirtIOBindings can probably be inlined into VirtioBusInfo.  I
> > don't see a need for separate structs.
> I agree. It might (or might not) be convenient to retain it
> temporarily while converting all the transports, but
> VirtIOBindings is part of the old code which we're trying
> to refactor here, and I'd expect it to go away when we're done.
>
> -- PMM
Yes, for the moment, I didn't refactor this VirtIOBindings, so it is 
better to separate struct to keep the virtiodevice binding function.