Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

[Stefan Priebe]

Am 24.11.2012 20:54, schrieb Blue Swirl:
> On Thu, Nov 22, 2012 at 10:00 AM, Stefan Priebe <address@hidden> wrote:
> > This one fixes a race which qemu had also in iscsi block driver
> > between cancellation and io completition.
> >
> > qemu_rbd_aio_cancel was not synchronously waiting for the end of
> > the command.
> >
> > To archieve this it introduces a new status flag which uses
> > -EINPROGRESS.
> >
> > Signed-off-by: Stefan Priebe <address@hidden>
...
> > -    qemu_aio_release(acb);
> > +    if (!acb->cancelled)
>
> Missing braces, please read CODING_STYLE.

Will fix this if the rest is OK. Waiting for Stefan and Paolo.

Stefan