Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset

[Jens Freimann]

On Fri, Nov 23, 2012 at 03:32:16PM +0100, Christian Borntraeger wrote:
> On 23/11/12 14:40, Alexander Graf wrote:
> > 
> > On 23.11.2012, at 11:18, Jens Freimann wrote:
> > 
> >> When resetting vcpus on s390/kvm we have to clear registers, psw
> >> and prefix as described in the z/Architecture PoP, otherwise a
> >> reboot won't work. IPL PSW and prefix are set later on by the
> >> s390-ipl device reset code.
> >>
> >> Signed-off-by: Jens Freimann <address@hidden>
> >> ---
> >> target-s390x/kvm.c | 26 +++++++++++++++++++++++++-
> >> 1 file changed, 25 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> >> index 94de764..b1b791e 100644
> >> --- a/target-s390x/kvm.c
> >> +++ b/target-s390x/kvm.c
> > 
> > This needs to go into generic vcpu reset code.
> 
> The kvm ioctl certainly not, no? (definitely necessary for kernels
> without sync regs).
> 
> I guess you are talking about moving the register initialisation 
> into s390_cpu_reset (target-s390x/cpu.c). Right? Jens can you have
> a look?

Yes, I'm  already looking into it. s390_cpu_reset() is only called when booting
the first time however because it's not registered as a reset handler. Trying to
find out how if I can convert it to a qemu reset handler or if I have to
do some QOM magic.

Jens

> Christian
> 

-- 
Mit freundlichen Grüßen / Kind regards 

Jens Freimann 

-- 
IBM Linux Technology Center / Boeblingen lab
IBM Systems &Technology Group, Systems Software Development
-------------------------------------------------------------
IBM Deutschland
Schoenaicher Str 220
71032 Boeblingen
Phone: +49-7031-16 x1122
E-Mail: address@hidden
-------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294